feat(eips): Make prague field an enum #1574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DoTheBestToGetTheBest
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
emhane
as code owners
mattsse
requested changes
Oct 27, 2024
tcoratger
reviewed
Oct 28, 2024
Co-authored-by: Thomas Coratger <[email protected]>
Co-authored-by: Thomas Coratger <[email protected]>
done thanks for the review |
onbjerg
requested changes
Oct 29, 2024
onbjerg
changed the title
|
@onbjerg hey sorry for the delay i'm having internet problem at home, does the change look good to you ? |
onbjerg
previously requested changes
Nov 11, 2024
crates/eips/src/eip7685.rs
Outdated
Comment on lines
80
to
84
| /// A list of requests or a precomputed requests hash. | ||
| /// | ||
| /// For testing purposes, the `Hash` variant stores a precomputed requests hash. This can be useful | ||
| /// when the exact contents of the requests are unnecessary, and only a consistent hash value is | ||
| /// needed to simulate the presence of requests without holding actual data. |
There was a problem hiding this comment.
the whitespaces in this comment are a bit funky, please reformat it :D
There was a problem hiding this comment.
the whitespaces in this comment are a bit funky, please reformat it :D
done
Co-authored-by: Oliver <[email protected]>
Co-authored-by: Oliver <[email protected]>
mattsse
approved these changes
Nov 27, 2024
mattsse
force-pushed
the
DoTheBestToGetTheBest-patch-3
branch
from
b40711e
to
db00324
Compare
klkvr
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1557